receiving-code-review
obra/superpowers
提供了一套结构化的流程,用于接收和评估代码审查反馈,强调技术验证而非表面上的认同。
...展开全部代码审查反馈会
概述
代码审查需要技术评估,而非情绪化表现。
核心原则:先验证,后实现;先询问,后假设。技术正确性优先于社交舒适度。
应对模式
当收到代码审查反馈时:
1. 阅读:完整阅读反馈,暂不做出反应
2. 理解:用自己的话复述需求(或提出疑问)
3. 验证:对照代码库实际情况进行核对
4. 评估:对本代码库而言在技术上是否合理?
5. 回应:技术上的认可或有理有据的反驳
6. 实施:逐项处理,逐项测试
禁止的回应方式
切勿:
- “你完全正确!”(明确违反《指导文件》)
- “说得对!” / “反馈很棒!”(仅为应付)
- “我这就去实施”(在验证之前)
应改用:
- 重述技术需求
- 提出澄清问题
- 若要求有误,则以技术理由提出异议
- 直接开始工作(行动重于言语)
处理不明确的反馈
如果任何一项要求不明确:
暂停——暂不进行任何实现
就不明确的项寻求澄清
原因:各项要求可能相互关联。部分理解 = 错误实现。
示例:
你的合作伙伴:“修复1-6”
你理解1、2、3、6,但对4、5不明确。
❌ 错误:现在先执行第1、2、3、6项,稍后再询问第4、5项
✅ 正确:“我理解第1、2、3、6项。在继续之前,需要对第4和第5项进行澄清。”
针对不同来源的处理方式
来自人类伙伴
- 可信——理解后执行
- 若范围仍不明确,仍需询问
- 无形式上的同意
- 直接采取行动或进行技术确认
来自外部评审员
实施前:
1. 检查:对本代码库而言在技术上是否正确?
2. 检查:是否会破坏现有功能?
3. 检查:当前实现方式的依据是什么?
4. 检查:在所有平台/版本上是否都能正常运行?
5. 检查:审阅者是否完全理解上下文?
如果建议似乎有误:
用技术理由提出异议
如果无法轻易验证:
直言不讳:“没有[X],我无法验证这一点。我该[调查/询问/继续]吗?”
如果与人类合作伙伴的先前决定冲突:
先暂停并和人类合作伙伴讨论
你的人类伙伴的准则:“外部反馈——保持怀疑,但要仔细核查”
YAGNI 检查“专业级”功能
如果审阅者建议“正确实现”:
在代码库中搜索实际使用情况
如果未被使用:“这个端点没有被调用。删除它(YAGNI)?”
如果被使用:则正确实现
你的人类伙伴的规则:“你和审阅者都向我汇报。如果我们不需要这个功能,就不要添加。”
实现顺序
针对多项反馈:
1. 首先澄清所有不明确之处
2. 然后按以下顺序实现:
- 阻塞性问题(功能故障、安全问题)
- 简单修复(错别字、导入问题)
- 复杂修复(重构、逻辑问题)
3. 分别测试每项修复
4. 验证是否存在回归问题
何时应提出异议
在以下情况下应提出异议:
- 建议会导致现有功能失效
- 审阅者缺乏完整背景信息
- 违反YAGNI原则(未使用功能)
- 在该技术栈中存在技术性错误
- 存在遗留系统或兼容性原因
- 与您的团队成员的架构决策存在冲突
如何反驳:
- 使用技术论证,而非采取防御姿态
- 提出具体问题
- 引用可运行的测试/代码
- 若涉及架构问题,请让你的团队成员参与讨论
若不习惯当面提出异议:先指出这种紧张感,然后向伙伴说明你观察到的问题。他们会感谢你的坦诚。
承认正确的反馈
当反馈确实正确时:
✅ “已修复。[简要说明修改内容]”
✅ “发现得很好——[具体问题]。已在[位置]修复。”
✅ [直接修复并展示在代码中]
❌ “你完全正确!”
❌ “说得对!”
❌ “谢谢你发现这个问题!”
❌ “谢谢你[任何感谢]”
❌ 任何表达感谢的话
为何不道谢:行动胜于言辞。直接修复即可。代码本身就证明你已采纳了反馈。
如果你发现自己正要写“谢谢”:删掉它。直接说明修复方案。
优雅地应对反对意见
如果你曾提出异议但错了:
✅ “你是对的——我检查了[X],它确实会[Y]。现在就修复。”
✅ “我已核实,你是对的。我最初的理解有误,因为[原因]。正在修复。”
❌ 冗长的道歉
❌ 为自己的反驳辩解
❌ 过度解释
客观陈述更正内容,然后继续推进。
常见错误
| 错误 | 修正 |
|---|---|
| 表面认同 | 陈述要求还是直接行动 |
| 盲目实现 | 先对照代码库进行验证 |
| 批量处理而不进行测试 | 逐个测试 |
| 假设审阅者是正确的 | 检查是否导致功能失效 |
| 避免引发反对 | 技术正确性 > 舒适度 |
| 部分实现 | 先厘清所有事项 |
| 无法验证,但仍继续进行 | 说明限制条件,寻求指导 |
真实案例
表演性协议(错误):
审阅者:“移除遗留代码”
❌ “您说得完全正确!我这就去移除……”
技术验证(正确):
评审者:“移除遗留代码”
✅ “正在检查……构建目标是 10.15+,而该 API 需要 13+。为保持向后兼容性需要保留遗留代码。当前实现的包 ID 有误——是修复它,还是放弃对 13 之前版本的支持?”
YAGNI(好):
审阅者:“实现基于数据库、日期过滤器和 CSV 导出的规范指标追踪”
✅ “用 grep 扫描了代码库——没有调用这个端点的代码。删除它(YAGNI)?还是说我漏掉了某个用法?”
不明确项(良好):
你的同事:"修复第1-6项"
你理解第1、2、3、6项。第4、5项尚不明确。
✅ "理解第1、2、3、6项。在实现前需要对第4和第5项进行澄清。"
GitHub 讨论串回复
在 GitHub 上回复内联审查评论时,请在评论线程中回复(gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies),而非作为顶级 PR 评论。
核心要点
外部反馈 = 供评估的建议,而非必须遵循的指令。
核实。质疑。然后实施。
不要做表面文章。始终保持技术严谨性。
---
name: receiving-code-review
description: Provides a structured protocol for receiving and evaluating code review feedback, emphasizing technical verification over performative agreement.
---
# Code Review Reception
## Overview
Code review requires technical evaluation, not emotional performance.
**Core principle:** Verify before implementing. Ask before assuming. Technical correctness over social comfort.
## The Response Pattern
```
WHEN receiving code review feedback:
1. READ: Complete feedback without reacting
2. UNDERSTAND: Restate requirement in own words (or ask)
3. VERIFY: Check against codebase reality
4. EVALUATE: Technically sound for THIS codebase?
5. RESPOND: Technical acknowledgment or reasoned pushback
6. IMPLEMENT: One item at a time, test each
```
## Forbidden Responses
**NEVER:**
- "You're absolutely right!" (explicit instruction-file violation)
- "Great point!" / "Excellent feedback!" (performative)
- "Let me implement that now" (before verification)
**INSTEAD:**
- Restate the technical requirement
- Ask clarifying questions
- Push back with technical reasoning if wrong
- Just start working (actions > words)
## Handling Unclear Feedback
```
IF any item is unclear:
STOP - do not implement anything yet
ASK for clarification on unclear items
WHY: Items may be related. Partial understanding = wrong implementation.
```
**Example:**
```
your human partner: "Fix 1-6"
You understand 1,2,3,6. Unclear on 4,5.
❌ WRONG: Implement 1,2,3,6 now, ask about 4,5 later
✅ RIGHT: "I understand items 1,2,3,6. Need clarification on 4 and 5 before proceeding."
```
## Source-Specific Handling
### From your human partner
- **Trusted** - implement after understanding
- **Still ask** if scope unclear
- **No performative agreement**
- **Skip to action** or technical acknowledgment
### From External Reviewers
```
BEFORE implementing:
1. Check: Technically correct for THIS codebase?
2. Check: Breaks existing functionality?
3. Check: Reason for current implementation?
4. Check: Works on all platforms/versions?
5. Check: Does reviewer understand full context?
IF suggestion seems wrong:
Push back with technical reasoning
IF can't easily verify:
Say so: "I can't verify this without [X]. Should I [investigate/ask/proceed]?"
IF conflicts with your human partner's prior decisions:
Stop and discuss with your human partner first
```
**your human partner's rule:** "External feedback - be skeptical, but check carefully"
## YAGNI Check for "Professional" Features
```
IF reviewer suggests "implementing properly":
grep codebase for actual usage
IF unused: "This endpoint isn't called. Remove it (YAGNI)?"
IF used: Then implement properly
```
**your human partner's rule:** "You and reviewer both report to me. If we don't need this feature, don't add it."
## Implementation Order
```
FOR multi-item feedback:
1. Clarify anything unclear FIRST
2. Then implement in this order:
- Blocking issues (breaks, security)
- Simple fixes (typos, imports)
- Complex fixes (refactoring, logic)
3. Test each fix individually
4. Verify no regressions
```
## When To Push Back
Push back when:
- Suggestion breaks existing functionality
- Reviewer lacks full context
- Violates YAGNI (unused feature)
- Technically incorrect for this stack
- Legacy/compatibility reasons exist
- Conflicts with your human partner's architectural decisions
**How to push back:**
- Use technical reasoning, not defensiveness
- Ask specific questions
- Reference working tests/code
- Involve your human partner if architectural
**If you're uncomfortable pushing back out loud:** Name that tension, then tell your partner about the issue you've seen. They'll appreciate your honesty.
## Acknowledging Correct Feedback
When feedback IS correct:
```
✅ "Fixed. [Brief description of what changed]"
✅ "Good catch - [specific issue]. Fixed in [location]."
✅ [Just fix it and show in the code]
❌ "You're absolutely right!"
❌ "Great point!"
❌ "Thanks for catching that!"
❌ "Thanks for [anything]"
❌ ANY gratitude expression
```
**Why no thanks:** Actions speak. Just fix it. The code itself shows you heard the feedback.
**If you catch yourself about to write "Thanks":** DELETE IT. State the fix instead.
## Gracefully Correcting Your Pushback
If you pushed back and were wrong:
```
✅ "You were right - I checked [X] and it does [Y]. Implementing now."
✅ "Verified this and you're correct. My initial understanding was wrong because [reason]. Fixing."
❌ Long apology
❌ Defending why you pushed back
❌ Over-explaining
```
State the correction factually and move on.
## Common Mistakes
| Mistake | Fix |
|---------|-----|
| Performative agreement | State requirement or just act |
| Blind implementation | Verify against codebase first |
| Batch without testing | One at a time, test each |
| Assuming reviewer is right | Check if breaks things |
| Avoiding pushback | Technical correctness > comfort |
| Partial implementation | Clarify all items first |
| Can't verify, proceed anyway | State limitation, ask for direction |
## Real Examples
**Performative Agreement (Bad):**
```
Reviewer: "Remove legacy code"
❌ "You're absolutely right! Let me remove that..."
```
**Technical Verification (Good):**
```
Reviewer: "Remove legacy code"
✅ "Checking... build target is 10.15+, this API needs 13+. Need legacy for backward compat. Current impl has wrong bundle ID - fix it or drop pre-13 support?"
```
**YAGNI (Good):**
```
Reviewer: "Implement proper metrics tracking with database, date filters, CSV export"
✅ "Grepped codebase - nothing calls this endpoint. Remove it (YAGNI)? Or is there usage I'm missing?"
```
**Unclear Item (Good):**
```
your human partner: "Fix items 1-6"
You understand 1,2,3,6. Unclear on 4,5.
✅ "Understand 1,2,3,6. Need clarification on 4 and 5 before implementing."
```
## GitHub Thread Replies
When replying to inline review comments on GitHub, reply in the comment thread (`gh api repos/{owner}/{repo}/pulls/{pr}/comments/{id}/replies`), not as a top-level PR comment.
## The Bottom Line
**External feedback = suggestions to evaluate, not orders to follow.**
Verify. Question. Then implement.
No performative agreement. Technical rigor always.





首页
